Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide tests for future timestamp formatting #6913

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Provide tests for future timestamp formatting #6913

merged 1 commit into from
Oct 23, 2017

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke
Provide tests for future timestamp formatting
ca4278a 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Oct 23, 2017
@MorrisJobke MorrisJobke mentioned this pull request Oct 23, 2017
Merged
@codecov
Copy link

codecov bot commented Oct 23, 2017

Codecov Report

Merging #6913 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6913      +/-   ##
============================================
+ Coverage     52.84%   52.85%   +0.01%     
  Complexity    22816    22816              
============================================
  Files          1441     1441              
  Lines         88555    88555              
  Branches       1349     1349              
============================================
+ Hits          46798    46807       +9     
+ Misses        41757    41748       -9
Impacted Files Coverage Δ Complexity Δ
lib/private/DateTimeFormatter.php 77.14% <0%> (+8.57%) 49% <0%> (ø) ⬇️

@LukasReschke LukasReschke merged commit 886bb31 into master Oct 23, 2017
@LukasReschke LukasReschke deleted the tests-for-6837 branch October 23, 2017 12:46
This was referenced Oct 23, 2017
Merged
Merged
@MorrisJobke
Copy link
Member Author

I added this commit directly to the backport PRs. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasReschke LukasReschke LukasReschke approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.
3 participants
@MorrisJobke @nickvergessen @LukasReschke