Fix 500 on setup page #7449
Merged
Fix 500 on setup page #7449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
commented
Dec 11, 2017
| // allows chrome workspace mapping in debug mode | ||
| return ""; | ||
| } | ||
| $v = \OC_App::getAppVersions(); |
There was a problem hiding this comment.
That one caused it - it's now wrapped into an "is installed" check. Otherwise the versions are empty and just skipped by the added checks below.
There was a problem hiding this comment.
To be fair I just noticed there is a direct version checker in https://github.com/nextcloud/server/blob/master/lib/private/legacy/app.php#L572
I never saw this since documentation is nowhere to be found 😢
|
The failing integration tests are fixed with #7342 |
|
If #7244 is backported this also needs to be backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #7244
cc @blizzz @rullzer @skjnldsv