Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable12] Fix 500 on setup page #8689

Merged
merged 1 commit into from
Mar 6, 2018
Merged

[stable12] Fix 500 on setup page #8689

merged 1 commit into from
Mar 6, 2018

Conversation

MorrisJobke
Copy link
Member

Backport of #7449

Most likely fixes the setup acceptance test issues on stable12.

Ref #8611

@MorrisJobke
Fix 500 on setup page
51b79a5 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 6, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0.6 milestone Mar 6, 2018
@MorrisJobke MorrisJobke mentioned this pull request Mar 6, 2018
Merged
danxuliu
danxuliu approved these changes Mar 6, 2018
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, and it fixes the setup integration tests 👍

Failing tests are unrelated; they were introduced in #8682, because use OCP\Util; is not included in Fetcher.php in the stable12 branch. Fixed in #8692

@MorrisJobke MorrisJobke merged commit 36c9b12 into stable12 Mar 6, 2018
@MorrisJobke MorrisJobke deleted the 12-7449 branch March 6, 2018 17:00
@MorrisJobke MorrisJobke mentioned this pull request Mar 9, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@danxuliu danxuliu danxuliu approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 12.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@MorrisJobke @rullzer @danxuliu