Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to force passwords for public conversations #13450

Closed
nickvergessen opened this issue Oct 2, 2024 · 2 comments · Fixed by #13767 or #13915
Closed

Add option to force passwords for public conversations #13450

nickvergessen opened this issue Oct 2, 2024 · 2 comments · Fixed by #13767 or #13915
Assignees

Comments

@nickvergessen
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Since we return the room object we can do this already, but the moderator has no way to see the password atm

@nickvergessen nickvergessen added this to the 🌠 Next Minor (30.1) milestone Oct 2, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💬 Talk team Oct 2, 2024
@nickvergessen nickvergessen moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 💬 Talk team Oct 2, 2024
@miaulalala miaulalala self-assigned this Nov 13, 2024
@miaulalala
Copy link
Contributor

miaulalala commented Nov 13, 2024

  • Config option to determine if server only allows password protected talk conversations
  • Change "create Room" endpoint (RoomController) to have a password option
  • Password policy checking on password not empty or config option set

If config option is given

  • Reject room creation if global password option is set an no password is given or it doesn't match password policy
  • RoomService -> setPassword as inspiration for how to store and validate a password

@miaulalala miaulalala moved this from 📄 To do (~10 entries) to 🏗️ In progress in 💬 Talk team Nov 13, 2024
@miaulalala
Copy link
Contributor

miaulalala commented Nov 14, 2024

The frontend part is missing, the backend part is finished. The password is stored as a promise and not submitted in the intial request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
2 participants