Feat: add option to force password in public conversations #13915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorraJaouad
added
enhancement
feature: frontend 🖌️
DorraJaouad
commented
Nov 30, 2024
Antreesy
reviewed
Dec 2, 2024
DorraJaouad
force-pushed
the
feat/13450/force-password-for-public-conversations
branch
from
a2a1990 to
c35edfd
Compare
Antreesy
reviewed
Dec 6, 2024
| await this.$store.dispatch('toggleGuests', { token: this.token, allowGuests, password: this.password }) | ||
| } else { | ||
| if (!allowGuests) { | ||
| await this.togglePassword(false) |
There was a problem hiding this comment.
That briefly show a warning, before changing room type
@miaulalala can we maybe remove password in RoomController::makePrivate()?
Antreesy
approved these changes
Dec 6, 2024
…config in set public type switch (conversation already created) Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
…don't support the new API endpoint Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
…password when force password protection is on Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
DorraJaouad
force-pushed
the
feat/13450/force-password-for-public-conversations
branch
from
445a876 to
4af1bc0
Compare
Antreesy
approved these changes
Dec 6, 2024
DorraJaouad
deleted the
feat/13450/force-password-for-public-conversations
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist