Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(conversations): add option to force passwords #13767

Merged
merged 1 commit into from
Nov 27, 2024
Merged

feat(conversations): add option to force passwords #13767

merged 1 commit into from
Nov 27, 2024

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Nov 13, 2024 •
edited
Loading

☑️ Resolves

in public conversations

🛠️ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@miaulalala miaulalala added this to the 🖤 Next Major (31) milestone Nov 13, 2024
@miaulalala miaulalala self-assigned this Nov 13, 2024
@miaulalala miaulalala added the feature: api 🛠️ OCS API for conversations, chats and participants label Nov 13, 2024
nickvergessen
nickvergessen reviewed Nov 13, 2024
View reviewed changes
docs/settings.md Outdated Show resolved Hide resolved
nickvergessen
nickvergessen reviewed Nov 13, 2024
View reviewed changes
lib/Controller/RoomController.php Outdated Show resolved Hide resolved
lib/Service/RoomService.php Outdated Show resolved Hide resolved
lib/Controller/RoomController.php Outdated Show resolved Hide resolved
@miaulalala miaulalala marked this pull request as ready for review November 14, 2024 18:19
nickvergessen
nickvergessen reviewed Nov 15, 2024
View reviewed changes
lib/Manager.php Show resolved Hide resolved
lib/Manager.php Show resolved Hide resolved
lib/Service/RoomService.php Outdated Show resolved Hide resolved
tests/php/Service/RoomServiceTest.php Outdated Show resolved Hide resolved
@nickvergessen
Copy link
Member

We also need 2 capabilities:

  1. A feature flag, so client can know when they can send the password in the createRoom request (and it needs to be documented in

    spreed/docs/conversation.md

    Line 130 in f8fef7d

    | `objectId` | string | Id of an object this room references, room token is used for the parent of a breakout room |
    )
  2. A config flag, if the password requirement is enforced

@nickvergessen nickvergessen mentioned this pull request Nov 15, 2024
Merged
@miaulalala miaulalala marked this pull request as draft November 18, 2024 12:03
@miaulalala miaulalala marked this pull request as ready for review November 18, 2024 17:07
nickvergessen
nickvergessen reviewed Nov 19, 2024
View reviewed changes
docs/conversation.md Outdated Show resolved Hide resolved
nickvergessen
nickvergessen reviewed Nov 19, 2024
View reviewed changes
lib/Service/RoomService.php Show resolved Hide resolved
lib/Service/RoomService.php Show resolved Hide resolved
lib/Service/RoomService.php Show resolved Hide resolved
lib/Service/RoomService.php Show resolved Hide resolved
@nickvergessen
Copy link
Member

Can you rebase, so CI runs?

@miaulalala miaulalala force-pushed the feat/add-password-config-option branch from ad9fb9f to 25d7135 Compare November 20, 2024 10:56
nickvergessen
nickvergessen requested changes Nov 20, 2024
View reviewed changes
docs/conversation.md Outdated Show resolved Hide resolved
lib/Controller/RoomController.php Outdated Show resolved Hide resolved
lib/Controller/RoomController.php Outdated Show resolved Hide resolved
lib/Controller/RoomController.php Outdated Show resolved Hide resolved
lib/Controller/RoomController.php Outdated Show resolved Hide resolved
lib/Controller/RoomController.php Outdated Show resolved Hide resolved
lib/Service/RoomService.php Outdated Show resolved Hide resolved
@nickvergessen
Copy link
Member

Almost there, just a small bug and some documentation fixes

@miaulalala miaulalala marked this pull request as draft November 21, 2024 14:27
@miaulalala miaulalala force-pushed the feat/add-password-config-option branch from f7e9726 to 4a5795f Compare November 25, 2024 11:28
@miaulalala miaulalala force-pushed the feat/add-password-config-option branch 2 times, most recently from cf54d5d to 010bb92 Compare November 27, 2024 13:47
@miaulalala miaulalala changed the title feat: add option to force passwords in public conversations feat(conversations): add option to force passwords Nov 27, 2024
@miaulalala miaulalala force-pushed the feat/add-password-config-option branch from 010bb92 to 3fd8877 Compare November 27, 2024 13:49
@miaulalala miaulalala marked this pull request as ready for review November 27, 2024 13:50
nickvergessen
nickvergessen reviewed Nov 27, 2024
View reviewed changes
docs/conversation.md Outdated Show resolved Hide resolved
docs/conversation.md Show resolved Hide resolved
lib/Controller/RoomController.php Outdated Show resolved Hide resolved
lib/Controller/RoomController.php Outdated Show resolved Hide resolved
@miaulalala miaulalala force-pushed the feat/add-password-config-option branch 2 times, most recently from d4e5cac to 9be40f3 Compare November 27, 2024 19:07
@nickvergessen
Copy link
Member

Need a command to recompile openapi :P

@miaulalala
feat(conversations): add option to force passwords in public conversa…
d77753d 
…tions

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the feat/add-password-config-option branch from 9be40f3 to d77753d Compare November 27, 2024 19:48
@nickvergessen nickvergessen merged commit fc6d414 into main Nov 27, 2024
71 checks passed
@nickvergessen nickvergessen deleted the feat/add-password-config-option branch November 27, 2024 19:58
@miaulalala miaulalala mentioned this pull request Dec 19, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad left review comments

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@miaulalala miaulalala

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Add option to force passwords for public conversations
3 participants
@miaulalala @nickvergessen @DorraJaouad