-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In fullscreen, neither the call actions menu nor the personal controls menu works, the viewer neither #5027
Comments
also broken in Talk 10.0.5 |
Also broken in 9 If we set that to the item we fullscreen it should work again? |
yes, that or boundariesElement. and find a good way to set the main container globally to all vues, like the store or mixins. |
Well additionally maybe, but it needs to "container"ed in the fullscreened element because everything else is not rendered/visible.
Please don't break everything again 🙈 |
I didn't mean reparenting, only exposing a reusable value to avoid repeating "document.getElementById('content-vue')" everywhere. I noticed that "this.$root.$el" contains that element too but the first time it's evaluated it contains the old element "#content" which gets replaced after Vue finishes it initialization. So not usable in a computed property. I guess a helper method will do, then, so that this gets reevaluated every time. |
|
PR for the Actions bit: #5270 others will need more work as they require to extend the nextcloud-vue components... |
|
PR for nextcloud-vue to add the container prop: nextcloud-libraries/nextcloud-vue#1734 |
PR for talk app adjustments: #5291 |
the tooltips are not working either. adding this I've also tried to set that value after switching to fullscreen, but it requires a re-render of the matching components to make it work |
all merged, now only the tooltip issue remains |
I've verified that the tooltip default only affects the Talk app by logging that setting inside another app that uses the library. |
In fullscreen, neither the call actions menu nor the personal controls menu works, the viewer neither.
The text was updated successfully, but these errors were encountered: