Use container property to fix popups in fulllscreen mode #5291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many popup components are usually appending themselves to the document body. This doesn't work in fullscreen mode where we use another component as the root. This fix sets the "container" property for all relevant popup components to make sure they can be visible in fullscreen mode. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
bugfix/5027/popup-use-container-for-fullscreen
branch
from
ab581f4 to
9eaa043
Compare
|
rebased to pick up library update |
|
please review |
marcoambrosini
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many popup components are usually appending themselves to the document
body. This doesn't work in fullscreen mode where we use another
component as the root.
This fix sets the "container" property for all relevant popup components
to make sure they can be visible in fullscreen mode.
Partial fix of #5027