Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(desktop): allow avatar menu on desktop #11675

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix(desktop): allow avatar menu on desktop #11675

merged 1 commit into from
Feb 28, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Feb 28, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Remove disabling the avatar menu on desktop

🏁 Checklist

@ShGKme ShGKme added this to the 💞 Next Major (29) milestone Feb 28, 2024
@ShGKme ShGKme self-assigned this Feb 28, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Feb 28, 2024

/backport to stable28

@ShGKme ShGKme force-pushed the desktop/allow-avatar-menu branch from b312c76 to bb586c3 Compare February 28, 2024 20:28
@ShGKme ShGKme requested a review from Antreesy February 28, 2024 20:31
@Antreesy
Copy link
Contributor

Please run npm lint, I'm not sure why imports were moved upwards

@ShGKme ShGKme force-pushed the desktop/allow-avatar-menu branch from bb586c3 to d7d69e3 Compare February 28, 2024 21:03
@ShGKme
fix(desktop): allow avatar menu on desktop
9a3a4b7 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the desktop/allow-avatar-menu branch from d7d69e3 to 9a3a4b7 Compare February 28, 2024 21:04
@ShGKme ShGKme enabled auto-merge February 28, 2024 21:04
@ShGKme ShGKme merged commit 3a5badd into main Feb 28, 2024
45 checks passed
@ShGKme ShGKme deleted the desktop/allow-avatar-menu branch February 28, 2024 21:10
@backportbot backportbot bot mentioned this pull request Feb 28, 2024
Merged
@ShGKme ShGKme mentioned this pull request Mar 5, 2024
Merged
@ShGKme ShGKme mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@ShGKme ShGKme

Labels
3. to review client: 💻 desktop feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Open NcAvatar's menu starts looped failed requesting
2 participants
@ShGKme @Antreesy