Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: "Share from Nextcloud" support #540

Merged
merged 5 commits into from
Feb 29, 2024
Merged

fix: "Share from Nextcloud" support #540

merged 5 commits into from
Feb 29, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Feb 28, 2024

☑️ Resolves

  • FilePicker ("Share from Nextcloud") support. It should have been working after migrating to @nextcloud/dialogs@5 but after some changes in @nextcloud/dialogs it hasn't been working again

🚧 Tasks

  • Handle initial state for non-existing app (otherwise getting optional Files configs crashed FilePicker)
  • Don't delete requesttocken header (it allows non-OCS-APIRequests requests like getting Files app configs)
    • I have no idea why I deleted this header 😶
    • Actually, it also allows requesting the contact menu for NcAvatar
  • Allow SEARCH and REPORT requests and X-Requested-With header (otherwise in DEV mode they are blocked by CORS)

@ShGKme
fix(patchers): handle initial state for non-existing app
467dff8 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(patchers): don't delete requesttocken header
29bebee 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(app): allow SEARCH and REPORT requests
faf4595 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(app): allow X-Requested-With header
0260d22 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(README): remove "Share from Nextcloud" from unsupported features
0a7b168 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review labels Feb 28, 2024
@ShGKme ShGKme self-assigned this Feb 28, 2024
@ShGKme ShGKme mentioned this pull request Feb 28, 2024
Merged
5 tasks
Antreesy
Antreesy approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, but icons are missing correct width/height:
image

@nickvergessen
Copy link
Member

Nice side catch! 🎉

@nickvergessen nickvergessen removed their request for review February 28, 2024 21:12
@ShGKme
Copy link
Contributor Author

ShGKme commented Feb 29, 2024

Works, but icons are missing correct width/height:

I cannot reproduce neither with stable28 nor with main

@ShGKme ShGKme merged commit d516b4a into main Feb 29, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/file-picker branch February 29, 2024 10:20
@ShGKme ShGKme mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShGKme @nickvergessen @DorraJaouad @Antreesy