-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sidebar): use open state to remove always working focus trap on mobile #12387
Conversation
375b8f9
to
42b9e50
Compare
@nextcloud/vue@8.13.0
@nextcloud/vue@8.13.0
@nextcloud/vue@8.13.0
@nextcloud/vue@8.13.0
3e745d0
to
2714865
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Though there are still too many styles changes came from library (follow-up?)
What do you mean? Are they from the library or new server styles? |
Styles on 30 are broken in many places also from server styles, it's in progress |
Yeah, server styles, I have compared at |
2714865
to
ad63ab8
Compare
|
ad63ab8
to
cf4dd79
Compare
Note, screenshot is made on stable29 styles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against stable29
on main ubread marker is still messy, but because of reducing the clickable area 44 -> 34
@DorraJaouad Is it much different from what was before? Styles on main, including |
Signed-off-by: Grigorii K. Shartsev <me@shgk.me> Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
a6794f6
to
b71a50c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
/backport to stable29 |
☑️ Resolves
@nextcloud/vue
from 8.11.3 to 8.13.0open
state ofNcAppSidebar
with built-in toggle button🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist