Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(sidebar): use open state to remove always working focus trap on mobile #12610

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 28, 2024

Backport of #12387

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added 3. to review bug feature: frontend 🖌️ "Web UI" client dependencies Pull requests that update a dependency file labels Jun 28, 2024
@backportbot backportbot bot added this to the 💚 Next Patch (29) milestone Jun 28, 2024
@ShGKme ShGKme force-pushed the backport/12387/stable29 branch 2 times, most recently from 99fad52 to 8eabfb7 Compare June 28, 2024 15:18
ShGKme
ShGKme previously approved these changes Jun 28, 2024
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted, tested

@ShGKme ShGKme marked this pull request as ready for review June 28, 2024 15:18
@ShGKme
Copy link
Contributor

ShGKme commented Jun 28, 2024

/backport to stable28

@DorraJaouad
Copy link
Contributor

Sidebar is not closing

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per Dorra comment

Antreesy and others added 3 commits July 12, 2024 14:00
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@Antreesy
Copy link
Contributor

Antreesy commented Jul 12, 2024

Bumped a library as per server, that seem to have been an issue:

8.13 8.14
image image

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@nickvergessen nickvergessen merged commit 06c0953 into stable29 Jul 12, 2024
46 checks passed
@nickvergessen nickvergessen deleted the backport/12387/stable29 branch July 12, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug dependencies Pull requests that update a dependency file feature: frontend 🖌️ "Web UI" client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants