Add support for Talk sidebar in Files app #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The rooms associated to a file are public rooms, so anyone could join them provided she knows its token. Thus, now it is enforced that only participants with direct access to the file can join the room. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Rooms associated to a file are persistent rooms, but they do not have any persistent participants, not even an owner (participants join and leave in each session). Thus these rooms should not be removed even if they are empty. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
In some cases there is no event to listen to for a change that affects the chat view, so it is not possible to explicitly save the scroll position when that change happens. Now the virtual list keeps track of the last known scroll position, and the chat view allows restoring to an arbitrary scroll position besides the saved one. This makes possible, for example, to restore to the last scroll position before the chat view was hidden (as long as it is possible to detect that the chat view is shown again, even if it was not possible to detect that it was hidden). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Some operations on the virtual list, like reloading it, updating the visible elements or scrolling to certain element, require that the container is visible. Before those operations messed with the state of the virtual list when called with a hidden container, but now they are simply ignored. Adding new elements is still possible while the virtual list is hidden, but "reload()" must be explicitly called once the container is visible again for the added elements to be loaded. Like in a regular "reload()", if the width has not changed there is no need to reload all the elements; only those that were added while the container was hidden will be added in that case. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This commit introduces a DetailTabView plugin to show a chat view in the sidebar of the Files app. The tab makes possible to chat in a Talk room associated to the current file; due to this, the tab is visible only on files that can be associated to a room, that is, files shared with the current user or by the current user to another user (as a user, group, circle...). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
… to the file Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
add-support-for-talk-sidebar-in-files-app
branch
from
6c8f499 to
811bd20
Compare
This was referenced Dec 6, 2018
marcoambrosini
pushed a commit
that referenced
this pull request
Oct 9, 2019
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.17.1 to 2.17.2. <details> <summary>Changelog</summary> *Sourced from [eslint-plugin-import's changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md).* > ## [2.17.2] - 2019-04-16 > > ### Fixed > - [`no-unused-modules`]: avoid crash when using `ignoreExports`-option ([#1331], [#1323], thanks [@​rfermann]) > - [`no-unused-modules`]: make sure that rule with no options will not fail ([#1330], [#1334], thanks [@​kiwka]) </details> <details> <summary>Commits</summary> - [`eddcfa9`](import-js/eslint-plugin-import@eddcfa9) Bump to v2.17.2 - [`b151d04`](import-js/eslint-plugin-import@b151d04) [fix] `no-unused-modules`: avoid crash when using `ignoreExports`-option - [`3512563`](import-js/eslint-plugin-import@3512563) [fix] `no-unused-modules`: make sure that rule with no options will not fail - [`8e0c021`](import-js/eslint-plugin-import@8e0c021) [Test] `no-unused-modules` add failing test case - [`9b7a970`](import-js/eslint-plugin-import@9b7a970) [meta] add `npm run mocha` for easier unit testing - See full diff in [compare view](import-js/eslint-plugin-import@v2.17.1...v2.17.2) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=eslint-plugin-import&package-manager=npm_and_yarn&previous-version=2.17.1&new-version=2.17.2) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @skjnldsv. [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1244 (see there for more details :-) ).