Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max-version to 16 #1331

Merged
merged 3 commits into from
Dec 10, 2018
Merged

Increase max-version to 16 #1331

merged 3 commits into from
Dec 10, 2018

Conversation

jancborchardt
Copy link
Member

So that it will work with current server master. Please review @nickvergessen @Ivansss @danxuliu

@nickvergessen
Copy link
Member

I'd like to avoid this for now, until we made the 15 release, because what we put in the appstore should not have 16 yet.

@nickvergessen nickvergessen added this to the 💛 Following Major milestone Dec 5, 2018
jancborchardt and others added 3 commits December 7, 2018 18:36
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member

Bumped the requirements
Bumped the version
Tests against master again

Ready for review and merged, since I branched of stable15 @nextcloud/talk

@nickvergessen nickvergessen merged commit b6661f8 into master Dec 10, 2018
@nickvergessen nickvergessen deleted the 16 branch December 10, 2018 11:19
marcoambrosini pushed a commit that referenced this pull request Oct 9, 2019
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.17.1 to 2.17.2.
<details>
<summary>Changelog</summary>

*Sourced from [eslint-plugin-import's changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md).*

> ## [2.17.2] - 2019-04-16
> 
> ### Fixed
> - [`no-unused-modules`]: avoid crash when using `ignoreExports`-option ([#1331], [#1323], thanks [@&#8203;rfermann])
> - [`no-unused-modules`]: make sure that rule with no options will not fail ([#1330], [#1334], thanks [@&#8203;kiwka])
</details>
<details>
<summary>Commits</summary>

- [`eddcfa9`](import-js/eslint-plugin-import@eddcfa9) Bump to v2.17.2
- [`b151d04`](import-js/eslint-plugin-import@b151d04) [fix] `no-unused-modules`: avoid crash when using `ignoreExports`-option
- [`3512563`](import-js/eslint-plugin-import@3512563) [fix] `no-unused-modules`: make sure that rule with no options will not fail
- [`8e0c021`](import-js/eslint-plugin-import@8e0c021) [Test] `no-unused-modules` add failing test case
- [`9b7a970`](import-js/eslint-plugin-import@9b7a970) [meta] add `npm run mocha` for easier unit testing
- See full diff in [compare view](import-js/eslint-plugin-import@v2.17.1...v2.17.2)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=eslint-plugin-import&package-manager=npm_and_yarn&previous-version=2.17.1&new-version=2.17.2)](https://dependabot.com/compatibility-score.html?dependency-name=eslint-plugin-import&package-manager=npm_and_yarn&previous-version=2.17.1&new-version=2.17.2)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @skjnldsv.

[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants