Add more information to PeerConnectionAnalyzer logs#14442
Merged
Conversation
5 tasks
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
danxuliu
force-pushed
the
add-more-information-to-peerconnectionanalyzer-logs
branch
from
9202347 to
9e2ccae
Compare
Antreesy
approved these changes
Apr 10, 2025
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Tested, looks good and verbose =)
Left some comments and nitpicks
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
add-more-information-to-peerconnectionanalyzer-logs
branch
from
9e2ccae to
3c593fb
Compare
Otherwise it was not possible to know if the logged stats belonged to the video or screen peer. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The raw RTC stats provide additional information that is sometimes needed to debug the connection quality warning, so they are now included in the logs. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Formatted strings were used instead of just a list of strings to ensure the proper format (as browsers typically add a space between arguments, but the Console object specification just suggests "a space or something similar", it does not explicitly require a space to be used). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
As the RTC stats "flood" the console output now the index of each group of stats as well as its index in the group is printed to ease differentiating them. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
add-more-information-to-peerconnectionanalyzer-logs
branch
from
d848230 to
f88e0fa
Compare
This was referenced May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #14095
Requires #14419 (as otherwise there would be conflicts once that one is merged)
The additional information in the logs should help to debug connection warnings and find out if they were legit or false positives that still need to be fixed.
Although it would not be strictly needed to backport this to 29 and 30 it might help to avoid conflicts with backports of future fixes.
TODO