[stable29] Add more information to PeerConnectionAnalyzer logs#15030
Closed
backportbot[bot] wants to merge 6 commits intostable29from
Closed
[stable29] Add more information to PeerConnectionAnalyzer logs#15030backportbot[bot] wants to merge 6 commits intostable29from
backportbot[bot] wants to merge 6 commits intostable29from
Conversation
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Otherwise it was not possible to know if the logged stats belonged to the video or screen peer. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The raw RTC stats provide additional information that is sometimes needed to debug the connection quality warning, so they are now included in the logs. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Formatted strings were used instead of just a list of strings to ensure the proper format (as browsers typically add a space between arguments, but the Console object specification just suggests "a space or something similar", it does not explicitly require a space to be used). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
As the RTC stats "flood" the console output now the index of each group of stats as well as its index in the group is printed to ease differentiating them. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Member
|
stable29 is EOL (and I forgot to remove the backport request... 🤦 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #14442