Skip to content

fix(chat): improve updating of unread marker from chat-relay#17049

Merged
Antreesy merged 1 commit intomainfrom
fix/noid/unread-update
Feb 11, 2026
Merged

fix(chat): improve updating of unread marker from chat-relay#17049
Antreesy merged 1 commit intomainfrom
fix/noid/unread-update

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 10, 2026

β˜‘οΈ Resolves

  • Fix inconsistency of unread-marker and conversations list update (difference between polling/chat-relay)

πŸ–ŒοΈ UI Checklist

πŸ–ΌοΈ Screenshots / Screencasts

🏚️ Before

2026-02-10_16h16_54.mp4

🏑 After (synced with LeftSidebar)

2026-02-10_16h18_00.mp4

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • πŸ–ŒοΈ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • πŸ“— User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/unread-update branch from da3108e to 8c9e7db Compare February 10, 2026 15:40
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is misleading :p you are fixing left sidebar update and not unread marker

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the LS lack of update but it costs a extra request per message ⚠️ . I am not sure if we should add this before final RC :/
At least we need a less expensive solution?

@Antreesy
Copy link
Contributor Author

This solves the LS lack of update but it costs a extra request per message

Amount of read requests is known to be large and should be handled separately. ATM I'm asking to focus on fixing the regression, and address read marker separately. WIll open an issue for that.

See screenshots:

State with long polling a.k.a stable32 State with chat-relay + this PR
image image

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine

@Antreesy
Copy link
Contributor Author

/backport to stable33

@Antreesy Antreesy merged commit a8af054 into main Feb 11, 2026
57 checks passed
@Antreesy Antreesy deleted the fix/noid/unread-update branch February 11, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants