[stable20.1] Enable pagination for main grid view #4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the grid view in development mode will behave like the grid view in normal mode. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This will be needed for proper calculations once pagination is enabled in the full grid view, as the local video will be shown in all pages and thus its slot will not be available. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Besides being cleaner this will make possible to fix the grid jumping back to the first page when the number of videos change. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When the number of participants changed or the window was resized the current page was reset to the first one. However, now that "displayedVideos" is a computed property and no longer reset directly in "makeGrid()" it is no longer necessary to go back to the first page. Moreover, as "numberOfPages" is also a computed property it can be watched to restrict the current page to be always in range. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When there was no longer an overflow the layout hint event was not triggered with a false value, so even if the window was resized to accomodate the larger number of participants the hint was not automatically removed. Now the hint is removed whenever there is no longer an overflow or the grid is shown as a stripe. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Instead of being explicitly emitted in "makeGrid" the layout hint is now automatically emitted based on the value of the computed properties that it depends on. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
As it is now possible to paginate in the main grid view the layout hint to change to speaker mode is no longer needed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
|
So not sure if this was also on master, but at least with the dev dummys if you have 10 and a 3*3 grid, on the first page you have 0-7 + you (looking good) and on page 2 you have 8-9+ you.
|
|
Yes, it is in master too. I was aware of it, but although I do not like it I did not find it so bad :-P Anyway I think it could be fixed by adding dummy elements (just empty divs) as padding in the last page so the main grid shows the local video always at the bottom right. |
|
Sounds good (enough) for now |
|
I think that this can also be accomplished with css grid rules only |
Oh, I have just seen it 🤦 Anyway the dirty fix is in #4996, feel free to do the proper fix and close that one :-) |
nickvergessen
deleted the
backport/4958/stable20.1-enable-pagination-for-main-grid-view
branch
This was referenced Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4958