Add padding for local video in last grid page #4996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the main grid is paginated the last page has less videos than the others. As the local video is shown after the remote videos this caused the local video to be shown at a different position than the rest of the pages. To solve this now empty divs are added to the last page of the grid as padding to fill the empty space in the grid and thus place the local video at the same position as in the other pages. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
|
closing in favor of #4999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4958
Fixes issue described in #4991 (comment)
When the main grid is paginated the last page has less videos than the others. As the local video is shown after the remote videos this caused the local video to be shown at a different position than the rest of the pages. To solve this now empty divs are added to the last page of the grid as padding to fill the empty space in the grid and thus place the local video at the same position as in the other pages.