Replace triangle sidebar trigger with dedicated icon, add icons to sidebar tabs and fix padding

[jancborchardt]

Sidebar trigger icon:

And in the sidebar:

Please review @danxuliu @nickvergessen @Ivansss

[danxuliu]

I like a lot the icons in the tab headers :-)

Regarding the other one... I still prefer my triangle :-P But even with #546 the triangle will have some consistency problems regarding the highlight (as it would highlight by being more clear while other elements will be highlighted by being more strong), so... I think it is a :+1 ;-)

However, shouldn't the shadow be more subtle on a white background? I know that it makes it more noticeable, but I think it is too much (not too much noticeable, I mean too much shadow; being noticeable is good ;-) ).

[jancborchardt]

@danxuliu Yeah, when we are still not in the call / on white background we could even just remove the icon-white icon-shadow classes from the icons. :)

Let’s do that in a separate pull request though. Is there a class which lets us know if we are in a call or not?

[danxuliu]

Is there a class which lets us know if we are in a call or not?

The incall class is added to the #app-content element... in theory. I have just seen that sometimes it is not added. Great... :-P

[nickvergessen]

Hmm not sure I like all these white icons on the white background (shadowed or not), I find them hard to see. Especially when the redshift kicks in. I'd say: either use grey/black like with all other icons, or stay with the triangle. (And yes, we can change the icon to white when you are switching into a call, so it's still visible on the black screen).

But 👍 for the icons on the tab headers.

[jancborchardt]

@nickvergessen yep, that's why I mentioned that we can simply show them as grey icons when on white background. :) Will do that, but in a separate PR.

[jancborchardt]

(Cause it's the same for the mute and video icons.)

[jancborchardt]

The dark icons are in #553 :)