More design fixes #553
Merged
More design fixes #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
…icons Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
…cipant fullscreen Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
…prevents text overlap Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
This was referenced Jan 9, 2018
Replace triangle sidebar trigger with dedicated icon, add icons to sidebar tabs and fix padding
#548
Merged
|
Dark icons are not very visible when the camera is on 😕 |
|
Depending on the window size and the video resolution, full screen and right side bar icons could even be completely invisible.
|
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
|
@Ivansss whoops, had some CSS in there which actually prevented the icons from ever becoming white. :) Now they are black whenever |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
|
@Ivansss pushed the changes: c3e7f09#diff-9c227ff7cd07ef67bd28fd246b54f5b7R382 As said I need you to add the »video-disabled« class which is on #hideVideo also to the #mute element directly before it whenever video is disabled. :) Then we’re good. |
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Ivansss
approved these changes
Jan 10, 2018
marcoambrosini
pushed a commit
that referenced
this pull request
Oct 9, 2019
…-plugin-nextcloud-0.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review @danxuliu @Ivansss @nickvergessen :)