Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unread message count to the room list #806

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

nickvergessen
Copy link
Member

Part 1 of #798

@nickvergessen nickvergessen added this to the 4.0 (Nextcloud 14) milestone Apr 23, 2018
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that in this case the counter should be more prominent than the default counter used in other apps so it is easier for the user to see that there are unread messages.

Current:
unread-message-count-current

Proposed (ignore the change in position, it was a quick hack :-) ):
unread-message-count-proposed

I would also make even more prominent when there is an unread mention (but that would be something for another pull request):
unread-message-count-proposed-future

@nickvergessen
Copy link
Member Author

Not our story, the navigation HTML+CSS is managed in the server repo, I'm just copying it to here. We will not change it to be different

@danxuliu
Copy link
Member

Yes, I know that the counter style comes from the server. But although consistency with the server is fine, if something does not fit with the needs of an app it should be changed in the app. And the counter of how many unread messages are in a conversation is not the same as, for example, the number of contacts in a group in the Contacts app, and it does not require the same degree of attention from the user either.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/noid/unread-message-count branch from 520ab54 to 47255e5 Compare April 24, 2018 14:28
@Ivansss Ivansss merged commit 16bc888 into master Apr 24, 2018
@Ivansss Ivansss deleted the feature/noid/unread-message-count branch April 24, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants