-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the unread count more obvious #824
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
@nickvergessen can you add it into server and the documentatino? |
We could have both. Just keep the current style where it is being used and add another rule in the server for child In the future it would be good to use a special highlighting for conversations in where you were mentioned (just changing the background color of the counter is not enough, as it would not be accessible), so further changes may be needed. But I guess that would be a need very specific to Talk more than something for the server. |
We could also make the number grey (like someone else was mentioned) and add a blue |
I think that it is already a big improvement, so I would merge this now and open an issue to discuss further ideas for 3.3/4.0. |
@skjnldsv Into your view component PR or where should I add it? |
@nickvergessen into the server for now. We'll add it into the component once done :) |
Let's do it
cc @skjnldsv maybe we can add something like this to the navigation directly. Yes blue may be unwanted for number of users in a group, but for unread count it sounds more important.