Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the unread count more obvious #824

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

nickvergessen
Copy link
Member

talk_-nextcloud-_2018-04-26_15 33 23

Let's do it

cc @skjnldsv maybe we can add something like this to the navigation directly. Yes blue may be unwanted for number of users in a group, but for unread count it sounds more important.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the 4.0 (Nextcloud 14) milestone Apr 26, 2018
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@skjnldsv
Copy link
Member

@nickvergessen can you add it into server and the documentatino?
It is a great addition :)

@danxuliu
Copy link
Member

maybe we can add something like this to the navigation directly. Yes blue may be unwanted for number of users in a group, but for unread count it sounds more important.

We could have both. Just keep the current style where it is being used and add another rule in the server for child .highlighted (or something like that) elements of .app-navigation-entry-utils-counter so it can be used where needed (for example, here).

In the future it would be good to use a special highlighting for conversations in where you were mentioned (just changing the background color of the counter is not enough, as it would not be accessible), so further changes may be needed. But I guess that would be a need very specific to Talk more than something for the server.

@nickvergessen
Copy link
Member Author

We could also make the number grey (like someone else was mentioned) and add a blue @ if you were mentioned

@danxuliu
Copy link
Member

I think that it is already a big improvement, so I would merge this now and open an issue to discuss further ideas for 3.3/4.0.

@Ivansss Ivansss merged commit 25423d9 into master Apr 27, 2018
@Ivansss Ivansss deleted the bugfix/noid/make-unread-count-more-obvious branch April 27, 2018 06:17
@nickvergessen
Copy link
Member Author

can you add it into server and the documentatino?
It is a great addition :)

@skjnldsv Into your view component PR or where should I add it?

@skjnldsv
Copy link
Member

skjnldsv commented May 2, 2018

@nickvergessen into the server for now. We'll add it into the component once done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants