Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new conversation #4064

Merged
merged 23 commits into from
Sep 5, 2024
Merged

Create new conversation #4064

merged 23 commits into from
Sep 5, 2024

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Aug 12, 2024

This PR includes:

  • Creates a new conversation
    • Create a public conversation.
    • Set a password for public conversation.
    • Add Participants.
    • Edit Participants.
    • Make conversation available for registered users and guest app users.

User avatar selection and adding participants through search will be implemented in a different PR.

These will be implemented in a different PR.

partly resolve #3794
partly resolve #1463

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi
Copy link
Collaborator

mahibi commented Sep 3, 2024

offline-support-bug-fixes must be merged first (fix to open the conversations that did not exist in conversation list yet)

@mahibi
Copy link
Collaborator

mahibi commented Sep 4, 2024

/backport to stable-20.0

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Codacy

Lint

TypemasterPR
Warnings8692
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Lint increased!

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
sowjanyakch and others added 12 commits September 5, 2024 15:41
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
otherwise response will be 400

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
...for ConversationCreationActivity and ContactsActivityCompose

just a quick fix, this may not be the best solution!

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi merged commit 38c1b6b into master Sep 5, 2024
12 of 16 checks passed
@mahibi mahibi deleted the create_new_conversation branch September 5, 2024 13:50
@backportbot backportbot bot mentioned this pull request Sep 5, 2024
2 tasks
Copy link
Contributor

github-actions bot commented Sep 5, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4064-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve Contacts activity (group creation, federation invitations, ...) Improve/Align group creation
2 participants