Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for offline support #4069

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Bug fixes for offline support #4069

merged 1 commit into from
Sep 4, 2024

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Aug 12, 2024

  • Fix duplicate messages
  • Fix duplicate conversations
  • Fix crashes on empty conversations
  • Unable to Join open conversations
  • Fix Unread messages not showing up correctly when entering a conversation see Bug fixes for offline support #4069 (review)
  • Delete all messages sometimes stops the UI from updating. Might be an issue with initMessagePolling

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004
Copy link
Contributor Author

See

#3952 (comment)
#3952 (comment)

@niclasheinz
Copy link

niclasheinz commented Aug 12, 2024

I would like to add the following to this comment #3952 (comment):

  • Storage Manager:
    Here you can set after how many weeks/months/years the chat messages/media files are automatically deleted locally.

  • Global settings:

    • Activate/deactivate offline support
    • Decide what is made available offline:
      • Messages
      • Media files such as images Documents
      • audios
      • surveys
      • Locations
      • Contacts

The same settings can be overwritten or adjusted in the individual chats.

@rapterjet2004 rapterjet2004 marked this pull request as ready for review August 13, 2024 16:13
@rapterjet2004 rapterjet2004 self-assigned this Aug 13, 2024
@rapterjet2004
Copy link
Contributor Author

/backport to stable-20.0

Copy link
Contributor

@sowjanyakch sowjanyakch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following has to be fixed.

  1. Unable to join open conversations.
  2. Delete messages of a conversation [Note to Self/ Group messages], then send a message. UI is not updated.

@AndyScherzinger
Copy link
Member

@rapterjet2004 Also broken atm is scrolling to the oldest unread message when entering a talk room with unread messages. Currently it simply renders right at the end of the conversation.

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8686
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a difference between lastReadMessage and lastCommonRead. The code in this PR mixes these things which creates new bugs. @rapterjet2004 Would you mind to revert everything to "Fix Unread messages not showing up correctly when entering a conversation" and i will fix it in a separate PR?

@mahibi
Copy link
Collaborator

mahibi commented Sep 3, 2024

I would like to add the following to this comment #3952 (comment):

* Storage Manager:
  Here you can set after how many weeks/months/years the chat messages/media files are automatically deleted locally.

* Global settings:
  
  * Activate/deactivate offline support
  * Decide what is made available offline:
    
    * Messages
    * Media files such as images Documents
    * audios
    * surveys
    * Locations
    * Contacts

The same settings can be overwritten or adjusted in the individual chats.

Thank you for the ideas @niclasheinz , some of them may be implemented in the future.

Got join conversation to work
Unread message popup should work when entering a conversation now
"Delete All Messages" now works without breaking the initMessagePolling
linter

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi merged commit 9e48c9a into master Sep 4, 2024
13 of 16 checks passed
@mahibi mahibi deleted the offline-support-bug-fixes branch September 4, 2024 08:15
@mahibi mahibi added this to the 20.1.0 milestone Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4069-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants