Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): Bump electron from 24.4.0 to 25.2.0 #237

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 22, 2023

Bumps electron from 24.4.0 to 25.2.0.

Release notes

Sourced from electron's releases.

electron v25.2.0

Release Notes for v25.2.0

Features

  • node: prefixed requires are now supported in sandboxed renderer preloads for events, timers and url. #38729 (Also in 24, 26)

Fixes

  • Fixed webContents.printToPDF preferCSSPageSize type error. #38791 (Also in 24, 26)
  • Fixed a crash seen when trying to change nativeTheme source during mara context menu close. #38839 (Also in 26)
  • Fixed an issue where webContents.print() stopped triggering its callback when the user cancelled the print dialog. #38814 (Also in 26)

Other Changes

  • Updated Chromium to 114.0.5735.134. #38782

electron v25.1.1

Release Notes for v25.1.1

Fixes

  • Added transparent color support for WCO on Windows. #38715 (Also in 26)
  • Fixed an error with webContents.print parameter validation by adding missing options required to set printer printable area. #38720 (Also in 26)
  • Fixed an issue where passing webContents.print(null) could incorrectly trigger an error. #38642 (Also in 24, 26)
  • Fixed an issue with potential use-after-free of child windows on close and reparent. #38678 (Also in 24, 26)
  • Fixed potential invalid protocol error handling. #38634 (Also in 26)
  • Fixed visibility of menu bar when exiting full screen. #38682 (Also in 23, 24, 26)

electron v25.1.0

Release Notes for v25.1.0

Features

  • Added setUSBProtectedClassesHandler to allow access to protected USB classes with WebUSB. #38493 (Also in 24)
  • Added setUSBProtectedClassesHandler to allow access to protected USB classes with WebUSB. #38493 (Also in 24)

Fixes

  • Fixed an issue where <datalist> popups are positions incorrectly in BrowserViews. #38609 (Also in 23, 24, 26)

Other Changes

  • Improved error message when contentTracing.stopRecording() fails because no trace was in progress. #38519 (Also in 23, 24)
  • Updated Chromium to 114.0.5735.91. #38516

electron v25.0.1

Release Notes for v25.0.1

Fixes

  • Fixed potential issues when minimizing parent windows with non-modal children on macOS. #38509 (Also in 24)

Other Changes

... (truncated)

Commits
  • fc5a7dd fix: crash on nativeTheme change during context menu close (#38839)
  • 1cb343e fix: webContents.print() cancellation callback (#38814)
  • 11c6f1f refactor: remove unused InspectableWebContentsView::GetWebView() (#38821)
  • c5e5b13 test: disable flaky asar worker test on ASan build (#38805)
  • f44be42 refactor: constexpr lookup tables (#38800)
  • 70fe0d9 feat: support node: prefixed requires in sandboxed renderer preloads (#38729)
  • cea70de chore: bump chromium to 114.0.5735.134 (25-x-y) (#38782)
  • 31b0daa fix: preferCSSPageSize error type (#38791)
  • 4249800 refactor: use compile-time cli arg sets. (#38768)
  • 2ba9860 docs: clarify supported accelerator punctuation (#38755)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/electron-25.2.0 branch 2 times, most recently from e80cff1 to ca2359b Compare June 22, 2023 08:53
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/electron-25.2.0 branch 3 times, most recently from 0e25a38 to 5fd6197 Compare June 22, 2023 08:57
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/electron-25.2.0 branch from 5fd6197 to ecf66bf Compare June 22, 2023 08:58
@ShGKme
Copy link
Contributor

ShGKme commented Jun 22, 2023

No breaking changes. Seems to work in general after the update.

But now the window with WebView has a scroll bar at least on Windows.

image

checking

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/electron-25.2.0 branch 2 times, most recently from 25d7b14 to 58d4a05 Compare June 22, 2023 09:02
Bumps [electron](https://github.com/electron/electron) from 24.4.0 to 25.2.0.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v24.4.0...v25.2.0)

---
updated-dependencies:
- dependency-name: electron
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/electron-25.2.0 branch from 58d4a05 to f846df8 Compare June 22, 2023 09:04
@ShGKme
Copy link
Contributor

ShGKme commented Jun 22, 2023

It should be a breaking change of the update according to the changelog and also it is an old known issue on Windows.

Nevertheless, it didn't happen to me before...
I'll make a fix in a minute

@ShGKme ShGKme merged commit 6cd766f into main Jun 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the dependabot/npm_and_yarn/electron-25.2.0 branch June 22, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant