Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(authentication): Use content size on login web-view to avoid scroll on Windows #238

Merged
merged 1 commit into from
Jun 22, 2023
Merged

fix(authentication): Use content size on login web-view to avoid scroll on Windows #238

merged 1 commit into from
Jun 22, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 22, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Use content size for window, so the window size will not include large window shadows on Windows

@ShGKme
fix(authentication): use content size on login web-view to avoid scroll
4ad84e3 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working regression os: Windows 🪟 labels Jun 22, 2023
@ShGKme ShGKme requested review from nickvergessen and Antreesy June 22, 2023 09:26
@ShGKme ShGKme self-assigned this Jun 22, 2023
Antreesy
Antreesy approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't check it on Linux, as here is no scroll observed, but according to docs everything seems to be proper 🦭
https://www.electronjs.org/docs/latest/api/browser-window#new-browserwindowoptions

@ShGKme ShGKme merged commit aa26957 into main Jun 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/use-content-size-on-login-web-view branch June 22, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@ShGKme ShGKme

Labels
bug Something isn't working os: Windows 🪟 regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShGKme @Antreesy