Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate icons to vue-material-design-icons #2345

Closed
juliusknorr opened this issue Apr 27, 2022 · 1 comment · Fixed by #2439
Closed

Migrate icons to vue-material-design-icons #2345

juliusknorr opened this issue Apr 27, 2022 · 1 comment · Fixed by #2439
Assignees
@vinicius73
Labels
1. to develop bug Something isn't working technical debt
Milestone
Nextcloud 25

Comments

@juliusknorr
Copy link
Member

Nextcloud 25 will drop support for SCSS and the icon generation that is currently in use in text (ref nextcloud/server#32060)

We need to make sure all icons are replaced with inline SVGs through vue-material-design-icons so they can then also properly adapt to the dark mode which is currently broken on master.

Other than that existing scss code form css/ should rather be moved to src/ and the corresponding components.
@juliusknorr juliusknorr added this to the Nextcloud 25 milestone Apr 27, 2022
@juliusknorr juliusknorr mentioned this issue Apr 27, 2022
Closed
46 tasks
@juliusknorr juliusknorr moved this to 📄 To do (5-20 entries) in 📝 Office team May 9, 2022
@juliusknorr
Copy link
Member Author

More urgent now that the icon classes are no longer generated with nextcloud/server#32326

I think to approach that we should basically expose an icon component from vue-material-design-icons in src/mixings/menubar.jsand make sure to use that instead of the icon class insrc/components/MenuBar.vue`

@vinicius73 vinicius73 self-assigned this May 11, 2022
@juliusknorr juliusknorr moved this from 📄 To do (5-20 entries) to 🏗️ In progress in 📝 Office team May 11, 2022
@juliusknorr juliusknorr mentioned this issue May 13, 2022
Merged
@vinicius73 vinicius73 mentioned this issue May 13, 2022
Closed
vinicius73 pushed a commit that referenced this issue May 17, 2022
🚧 (#2345): use material design icons
fab8ffd 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 17, 2022
♻️ (#2345) split menu bar in small components
e44dccf 
improves performance and responsivity
isolates responsability of image upload
vinicius73 pushed a commit that referenced this issue May 17, 2022
⚰️ (#2345): remove unused methods and codes
111b8ee
vinicius73 pushed a commit that referenced this issue May 17, 2022
♻️ (#2345) split menu bar in small components
8828cc8 
improves performance and responsivity
isolates responsability of image upload

Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 17, 2022
⚰️ (#2345): remove unused methods and codes
a5fe788 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 21, 2022
🚚 (#2345): rename components
3b8aaec 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 21, 2022
✨ (#2345): add ActionList
8528429 
improve style/ux

Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 21, 2022
🚸 (#2345): add Remaining Actions
7c1884e 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 21, 2022
💄 (#2345): improve fullscreen menu bar
3f1a006 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 23, 2022
💄 (#2345): table icons
5e8f077 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 23, 2022
💄 (#2345): add refocus
3903f44 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 23, 2022
⚰️ (#2345): remove unused attribute
d0bff88 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@vinicius73 vinicius73 mentioned this issue May 23, 2022
Merged
5 tasks
vinicius73 pushed a commit that referenced this issue May 23, 2022
♻️ (#2345): remove id selectors
783bfa0 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 23, 2022
✅ (#2345): fix share tests
c7a7723 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 23, 2022
✅ (#2345): fix viewer tests
6e83554 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 23, 2022
✅ (#2345): fix links tests
bf27bd9 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 23, 2022
🚧 (#2345): workspace tests
7c07720 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 25, 2022
🐛 (#2345): fix upload state reactivity
fbe7f11 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 25, 2022
🚸 (#2345): use 20px as default size for all icons
13e2a0d 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 25, 2022
♻️ (#2345): small adjust
bf8f930 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 25, 2022
⚰️ (#2345): remove unused component
b309fb3 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 25, 2022
💚 (#2345): fix inconsistent test
d791da3 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 25, 2022
💚 (#2345): fix inconsistent test
4df8202 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 26, 2022
🚸 (#2345): adjust menubar position
99f40d3 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 26, 2022
🚚 (#2345): rename Menu.vue -> MenuBar.vue
bb02c39 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 26, 2022
🚚 (#2345): rename ActionEntry.mixin.js -> BaseActionEntry.js
12cadee 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 26, 2022
♻️ (#2345): rename _key -> key
1d699f5 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 26, 2022
🚚 (#2345): rename EditorDraggable -> EditorMidiaHandler
f5429f8 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 26, 2022
🚸 (#2345): remove menubar flickering
242cc9c 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 26, 2022
🐛 (#2345): fix missing static class
11bd79a 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 26, 2022
♻️ (#2345): make Callout as a component
46ad510 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 26, 2022
🐛 (#2345): fix pass through of props
9dfa141 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 26, 2022
🐛 (#2345): fix missing event trigged when actionEntry have an click i…
ebb5ccd 
…nstead of a action

Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 26, 2022
🐛 (#2345): fix missing help modal
bb05046 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 27, 2022
⚰️ (#2345): remove unused icons
acfb264 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 27, 2022
🩹 (#2345): remove test code
956f95a 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 30, 2022
🐛 (#2345): fix wrong condiction
dd7c8aa 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 30, 2022
✏️ (#2345): typofix
c6496ff 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 30, 2022
✏️ (#2345): typofix
02f8944 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 30, 2022
🩹 (#2345): improve ActionList component
3286d1b 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 30, 2022
🩹 (#2345): prevent error when file is undefined
08ef254 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 30, 2022
✨ (#2345): more icons
66bdbaf 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 30, 2022
💄 (#2345): use mdi icons in bubble menu
a3a438e 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 30, 2022
🎨 (#2345): sort icons
4ad919a 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73 pushed a commit that referenced this issue May 31, 2022
🩹 (#2345): use nextcloud button instead of html button
6345231 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Repository owner moved this from 🏗️ In progress to ☑️ Done in 📝 Office team May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinicius73 vinicius73

Labels
1. to develop bug Something isn't working technical debt
Projects
📝 Office team
Archived in project
Milestone
Nextcloud 25
Development

Successfully merging a pull request may close this issue.

Migrate icons to vue material design icons nextcloud/text
2 participants
@vinicius73 @juliusknorr