Migrate icons to vue material design icons #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
May 13, 2022 15:58
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
improves performance and responsivity isolates responsability of image upload Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
…to-vue-material-design-icons
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
improve style/ux Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
…to-vue-material-design-icons
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73
added
enhancement
added 9 commits
May 23, 2022 17:41
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
…to-vue-material-design-icons
added 2 commits
May 27, 2022 13:32
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
…hub.com:nextcloud/text into 2345-migrate-icons-to-vue-material-design-icons
juliusknorr
reviewed
May 27, 2022
| <EmojiPicker class="entry-action entry-action__emoji" | ||
| :data-text-action-entry="actionEntry.key" | ||
| @selectData="addEmoji"> | ||
| <button v-tooltip="actionEntry.label" |
There was a problem hiding this comment.
We could switch to the @nextcloud/vue button component here in order to avoid custom styling from https://github.com/nextcloud/text/pull/2439/files#diff-ad1f213fdd71dfbb7fd8df37ade6a17b7c16e70098218a4b76cce502ee857eabR18
That way the styles should also be the same as with the other icons in regards to opacity and focus style:
juliusknorr
approved these changes
May 27, 2022
|
One other small thing, some buttons (the Actions with a submenu) seem to have a slightly different focus-visible style:
But maybe something to report in server/nextcloud-vue |
julien-nc
requested changes
May 30, 2022
added 2 commits
May 30, 2022 10:16
…to-vue-material-design-icons
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
|
No more comments, impressive changes. |
added 2 commits
May 30, 2022 12:44
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nimishavijay
requested changes
May 30, 2022
There was a problem hiding this comment.
Really really nice! Amazing work :)
I only have 2 tiny changes:
- The icons for "Info" and "Warning" look very similar so I would suggest using the triangle icon alert instead
- For "Add link" we could use the icon link as I think it is more recognisable for adding links. I do remember there being a discussion about the icons for "Add link" and "Attachment" being too similar, though. @jancborchardt what do you think?
Other those 2 points it is super cool!
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
|
I've changed the icons @nimishavijay |
added 4 commits
May 30, 2022 15:53
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
delete-merged-branch
bot
deleted the
2345-migrate-icons-to-vue-material-design-icons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes MenuBar implementation to use Material Design Icons.
The previous implementation of MenuBar was very bounded with icon classes.
To migrate to MDI we have changed the implementation to a modern and performant approach.