Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Nextcloud Text (MarkDown files): Useless and strange notification: "remote user" changed {file} #2821

Closed
6 of 9 tasks
Jerome-Herbinet opened this issue Aug 21, 2022 · 5 comments · Fixed by #3356 or #3390
Closed
6 of 9 tasks
Assignees
Labels
2. developing bug Something isn't working high

Comments

@Jerome-Herbinet
Copy link
Member

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

From my Android smartphone, with my official Nextcloud 3.21.0 application, when I open a ".md" file (Nextcloud Text), I receive the following push notification (i don't receive e-mail notification) : "remote user" changed {file}

Context: The notification setting "A file or folder has been changed" is active (push and email)

2 problems:

  • I receive this notification while the MarkDown file belongs to me and I modified it from my smartphone, with the Nextcloud app connected with my user. By chance I don't receive this notification when I make a modification from the web interface (in this case, no notification, which is consistent). I should never get a notification when I edit one of my files, no matter where or how I do it.
  • What really makes me think of a bug is that the notification starts with "remote user" ... it's illogical and incomprehensible. At worst, it should have my full user name instead.

To conclude, either I didn't understand the behavior and the utility of the notification parameter "A file or folder has been changed" (and I should be given arguments), or there is a bug.

Steps to reproduce

  1. Enable "A file or folder has been changed" push notification option
  2. Create an md file with Nextcloud Text
  3. Open it, edit it and wait for auto-saving
  4. If you have the same bug as me, you should get the push notification I described.

Expected behavior

I should not receive any such notification in this context. I don't need to be notified when I modify a file of my own.

Installation method

Community Web installer on a VPS or web space

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.0

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 22.2.3 to 22.2.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "instanceid": "***REMOVED SENSITIVE VALUE***",
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "secret": "***REMOVED SENSITIVE VALUE***",
    "trusted_domains": [
        "nextcloud.mydomain.fr"
    ],
    "datadirectory": "***REMOVED SENSITIVE VALUE***",
    "dbtype": "mysql",
    "version": "24.0.4.1",
    "updatechecker": true,
    "overwrite.cli.url": "https:\/\/nextcloud.mydomain.fr",
    "dbname": "***REMOVED SENSITIVE VALUE***",
    "dbhost": "***REMOVED SENSITIVE VALUE***",
    "dbport": "",
    "dbtableprefix": "oc_",
    "mysql.utf8mb4": true,
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "installed": true,
    "filelocking.enabled": true,
    "filelocking.ttl": 3600,
    "default_language": "fr",
    "default_locale": "fr_FR",
    "default_phone_region": "ISO3166-2",
    "mail_from_address": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpmode": "smtp",
    "mail_sendmailmode": "smtp",
    "mail_domain": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpauthtype": "LOGIN",
    "mail_smtpauth": 1,
    "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpport": "25",
    "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
    "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
    "memcache.local": "\\OC\\Memcache\\Redis",
    "memcache.locking": "\\OC\\Memcache\\Redis",
    "redis": {
        "host": "***REMOVED SENSITIVE VALUE***",
        "port": 6379
    },
    "maintenance": false,
    "theme": "",
    "loglevel": 2,
    "updater.release.channel": "stable",
    "app_install_overwrite": [
        "occweb"
    ]
}

List of activated Apps

Enabled:
 - accessibility: 1.10.0
 - activity: 2.16.0
 - announcementcenter: 6.3.1
 - apporder: 0.15.0
 - bruteforcesettings: 2.4.0
 - calendar: 3.4.2
 - circles: 24.0.1
 - cloud_federation_api: 1.7.0
 - comments: 1.14.0
 - contacts: 4.2.0
 - contactsinteraction: 1.5.0
 - dashboard: 7.4.0
 - dav: 1.22.0
 - deck: 1.7.1
 - external: 4.0.0
 - federatedfilesharing: 1.14.0
 - federation: 1.14.0
 - files: 1.19.0
 - files_accesscontrol: 1.14.1
 - files_automatedtagging: 1.14.0
 - files_external: 1.16.1
 - files_linkeditor: 1.1.11
 - files_lock: 24.0.1
 - files_pdfviewer: 2.5.0
 - files_readmemd: 1.2.2
 - files_rightclick: 1.3.0
 - files_sharing: 1.16.2
 - files_trashbin: 1.14.0
 - files_versions: 1.17.0
 - files_videoplayer: 1.13.0
 - firstrunwizard: 2.13.0
 - flow_notifications: 1.4.0
 - groupfolders: 12.0.1
 - impersonate: 1.11.0
 - jitsi: 0.15.0
 - logreader: 2.9.0
 - lookup_server_connector: 1.12.0
 - metadata: 0.16.0
 - nextcloud_announcements: 1.13.0
 - notes: 4.5.0
 - notifications: 2.12.0
 - oauth2: 1.12.0
 - occweb: 0.1.0
 - password_policy: 1.14.0
 - passwords: 2022.6.20
 - phonetrack: 0.7.0
 - photos: 1.6.0
 - privacy: 1.8.0
 - provisioning_api: 1.14.0
 - quota_warning: 1.14.0
 - recommendations: 1.3.0
 - richdocuments: 6.2.0
 - richdocumentscode: 22.5.502
 - serverinfo: 1.14.0
 - settings: 1.6.0
 - sharebymail: 1.14.0
 - spreed: 14.0.4
 - support: 1.7.0
 - survey_client: 1.12.0
 - systemtags: 1.14.0
 - text: 3.5.1
 - theming: 1.15.0
 - theming_customcss: 1.11.0
 - twofactor_backupcodes: 1.13.0
 - twofactor_email: 2.5.0
 - twofactor_nextcloud_notification: 3.4.0
 - twofactor_totp: 6.4.0
 - updatenotification: 1.14.0
 - user_status: 1.4.0
 - video_converter: 1.0.5
 - viewer: 1.8.0
 - weather_status: 1.4.0
 - welcome: 1.0.1
 - workflowengine: 2.6.0
Disabled:
 - admin_audit
 - duplicatefinder: 0.0.15
 - encryption
 - extract: 1.3.5
 - files_zip: 1.1.2
 - user_ldap

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

Can be provided if necessary

Additional info

No response

@Jerome-Herbinet Jerome-Herbinet added 0. Needs triage bug Something isn't working labels Aug 21, 2022
@Jerome-Herbinet Jerome-Herbinet changed the title [Bug]: Nextcloud Text (MarkDown files): Useless and strange notification: "{user} changed {file}" [Bug]: Nextcloud Text (MarkDown files): Useless and strange notification: "remote user" changed {file} Aug 21, 2022
@szaimen szaimen transferred this issue from nextcloud/server Aug 21, 2022
@XueSheng-GIT
Copy link

See also: nextcloud/android#10237

@Jerome-Herbinet
Copy link
Member Author

@szaimen I've seen that you moved my issue ; I wonder if it is not a more upstream problem when reading the issue of @XueSheng-GIT ... with several use contexts (see above nextcloud/android#10237) ; or should his issue (and mine) be both moved elsewhere ? Thanks for reading.

@szaimen
Copy link
Contributor

szaimen commented Aug 22, 2022

I think it is an issue within the text app.

@juliusknorr
Copy link
Member

Might be either a text or server issue with the direct editing API if the current user is not properly set in the session

marcelklehr added a commit that referenced this issue Nov 4, 2022
to have it available for the file put activities event

fixes nextcloud/android#10237
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Nov 4, 2022
@marcelklehr marcelklehr moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Nov 4, 2022
marcelklehr added a commit that referenced this issue Nov 4, 2022
to have it available for the file put activities event

fixes nextcloud/android#10237
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr self-assigned this Nov 4, 2022
Repository owner moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Nov 7, 2022
backportbot-nextcloud bot pushed a commit that referenced this issue Nov 7, 2022
to have it available for the file put activities event

fixes nextcloud/android#10237
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
backportbot-nextcloud bot pushed a commit that referenced this issue Nov 7, 2022
to have it available for the file put activities event

fixes nextcloud/android#10237
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
backportbot-nextcloud bot pushed a commit that referenced this issue Nov 7, 2022
to have it available for the file put activities event

fixes nextcloud/android#10237
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
max-nextcloud pushed a commit that referenced this issue Nov 7, 2022
to have it available for the file put activities event

fixes nextcloud/android#10237
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
max-nextcloud pushed a commit that referenced this issue Nov 7, 2022
to have it available for the file put activities event

fixes nextcloud/android#10237
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
max-nextcloud pushed a commit that referenced this issue Nov 7, 2022
to have it available for the file put activities event

fixes nextcloud/android#10237
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
backportbot-nextcloud bot pushed a commit that referenced this issue Nov 7, 2022
to have it available for the file put activities event

fixes nextcloud/android#10237
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@XueSheng-GIT
Copy link

I've applied https://patch-diff.githubusercontent.com/raw/nextcloud/text/pull/3371.diff to my NC25 instance, but I'm still facing the issue that "remote user" is in the activity stream if markdown files are edited within the android app. Anything else which must be done to solve this issue?

@marcelklehr marcelklehr reopened this Nov 8, 2022
marcelklehr added a commit that referenced this issue Nov 8, 2022
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
max-nextcloud pushed a commit that referenced this issue Nov 9, 2022
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
max-nextcloud pushed a commit that referenced this issue Nov 9, 2022
to have it available for the file put activities event

fixes nextcloud/android#10237
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
backportbot-nextcloud bot pushed a commit that referenced this issue Nov 9, 2022
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
backportbot-nextcloud bot pushed a commit that referenced this issue Nov 9, 2022
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
backportbot-nextcloud bot pushed a commit that referenced this issue Nov 9, 2022
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
max-nextcloud pushed a commit that referenced this issue Nov 9, 2022
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
max-nextcloud pushed a commit that referenced this issue Nov 9, 2022
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
max-nextcloud pushed a commit that referenced this issue Nov 9, 2022
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
backportbot-nextcloud bot pushed a commit that referenced this issue Nov 9, 2022
fixes #2821

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing bug Something isn't working high
Projects
Archived in project
6 participants