DirectEditing: Set session user for DirectSession editing #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
requested review from
juliusknorr,
a team and
max-nextcloud
and removed request for
a team
|
Not sure if this is the best approach. Advice is welcome :) |
to have it available for the file put activities event fixes nextcloud/android#10237 fixes #2821 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
fix/no-user-in-file-put-event
branch
from
c566b6f
to
468f4e3
Compare
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
juliusknorr
approved these changes
Nov 4, 2022
|
The failing cypress test was about fetching a preview for a |
|
Since this was reported with NC 22 i think it will require backports. I'll try and trigger them. |
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable23 |
max-nextcloud
approved these changes
Nov 7, 2022
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
|
Same test failed again - but this really does not look like a related issue. Will merge anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes nextcloud/android#10237
fixes #2821
Summary
Set session user for DirectSession editing to have it available for the file put activities event