Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues when reconnecting #4340

Closed
juliusknorr opened this issue Jun 21, 2023 · 0 comments · Fixed by #4474
Closed

Issues when reconnecting #4340

juliusknorr opened this issue Jun 21, 2023 · 0 comments · Fixed by #4474
Labels
1. to develop bug Something isn't working feature: sync high

Comments

@juliusknorr
Copy link
Member 

          Found two other reconnect bug when testing but those would be something for a different round:
  • Open text
  • Set to offline in network tab of browser console
  • Click reconnect
  • 🐛 It seems to show an error but request still happen and there is a continuous loading spinner
  • Open text
  • Delete the oc_text_session entry
  • 🐛 See an empty editor

Originally posted by @juliushaertl in #4297 (comment)
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jun 21, 2023
mejo- added a commit that referenced this issue Jul 10, 2023
@mejo-
fix(editor): Don't reconnect Editor on connection issues
5b4878f 
SyncService will resend failed steps after network has recovered.

Remove obsolete `data.retry` flag when emitting error of
`ERROR_TYPE.CONNECTION_FAILED`.

Fixes: #4340

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- mentioned this issue Jul 10, 2023
Merged
7 tasks
mejo- added a commit that referenced this issue Jul 11, 2023
@mejo-
fix(editor): Don't reconnect Editor on connection issues
94ce37f 
SyncService will resend failed steps after network has recovered.

Remove obsolete `data.retry` flag when emitting error of
`ERROR_TYPE.CONNECTION_FAILED`.

Fixes: #4340

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Jul 11, 2023
@mejo-
fix(editor): Don't reconnect Editor on connection issues
3440159 
SyncService will resend failed steps after network has recovered.

Remove obsolete `data.retry` flag when emitting error of
`ERROR_TYPE.CONNECTION_FAILED`.

Fixes: #4340

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Jul 11, 2023
@mejo-
fix(editor): Don't reconnect Editor on connection issues
fee8224 
SyncService will resend failed steps after network has recovered.

Remove obsolete `data.retry` flag when emitting error of
`ERROR_TYPE.CONNECTION_FAILED`.

Fixes: #4340

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Jul 11, 2023
@mejo-
fix(editor): Don't reconnect Editor on connection issues
58fc762 
SyncService will resend failed steps after network has recovered.

Remove obsolete `data.retry` flag when emitting error of
`ERROR_TYPE.CONNECTION_FAILED`.

Fixes: #4340

Signed-off-by: Jonas <jonas@freesources.org>
@github-project-automation github-project-automation bot moved this from 🧭 Planning evaluation (don't pick) to ☑️ Done in 📝 Office team Jul 11, 2023
mejo- added a commit that referenced this issue Jul 11, 2023
@mejo-
fix(editor): Don't reconnect Editor on connection issues
f1ff5a0 
SyncService will resend failed steps after network has recovered.

Remove obsolete `data.retry` flag when emitting error of
`ERROR_TYPE.CONNECTION_FAILED`.

Fixes: #4340

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Jul 11, 2023
@mejo-
fix(editor): Don't reconnect Editor on connection issues
44c3d7f 
SyncService will resend failed steps after network has recovered.

Remove obsolete `data.retry` flag when emitting error of
`ERROR_TYPE.CONNECTION_FAILED`.

Fixes: #4340

Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop bug Something isn't working feature: sync high
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sync errors after network issues nextcloud/text
1 participant
@juliusknorr