-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit sync event after successful push to pick up syncing again #4297
Conversation
2 flaky tests on run #10379 ↗︎
Details:
sync.spec.js • 1 flaky test
api/UsersApi.spec.js • 1 flaky test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Found two other reconnect bug when testing but those would be something for a different round:
|
@max-nextcloud Do you have any suggestion or code pointer how we do that in other cypress tests? Might be worth to look into separating the save request soonish ;) |
Looks like the We have this in a bunch of places and my usual workaround was to wait for at least two syncs. Used to be so that first sync ensures steps by others are synced and second sync could then make sure we are up to date with our own steps. I think if we fix the actual issue and maybe separate the save and sync requests we could get rid of a few of those waits. |
The only example of that pattern i could find outside the directediting spec is unrelated: So maybe we got rid of them already. |
abc342d
to
663885b
Compare
cypress/e2e/sync.spec.js
Outdated
@@ -64,28 +64,28 @@ describe('Sync', () => { | |||
.should('include', 'saves the doc state') | |||
}) | |||
|
|||
it('recovers from a lost connection', () => { | |||
it.only('recovers from a lost connection', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for looking into this @juliushaertl! Code changes look sensible to me (apart from .only
in the Cypress test).
663885b
to
90d51cc
Compare
/compile |
c4c9d50
to
292ee76
Compare
/compile |
292ee76
to
9225acd
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
9225acd
to
25256c6
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
🚧 TODO
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)