-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes menu entry. #2292
Changes menu entry. #2292
Conversation
Hi @pierreozoux Thanks a lot for your proposal. I'm a bit unsure about using 'Note' instead as there is a Notes app - so this might be confusing if you create a note somewhere and then it does not show in the notes app (because that app only works on one folder). I agree that My personal preference would be just I'd be really curious what @jancborchardt and @nimishavijay think. |
@ImaCrea what do you think? |
What about |
The text app is advertised and documented as a text editor so from my perspective either "New text document" or "New text file" are the most fitting terms. Pad is not really a term that is understandable for non-technical users from my perspective and note is something that may add a wrong connection to the notes app, but I would appreciate feedback from @jancborchardt and @nimishavijay here as well :) |
Understood. |
I can understand how it could be confusing when there is a "New document" right underneath. |
Yep, agree with the points made by @max-nextcloud @juliushaertl and @nimishavijay. Let’s go for "New text file". :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment for the wording as per discssion, in addition the wording in
text/lib/AppInfo/Application.php
Line 71 in 551729e
$markdownFile = new TemplateFileCreator(Application::APP_NAME, $l->t('New text document'), '.md'); |
Looks good for the frontend part, could you also adjust that accordingly in text/lib/AppInfo/Application.php Line 71 in 551729e
|
2938eb2
to
3ba29a5
Compare
@juliushaertl I think I did all the changes, looks goot to 🚢 to me :) |
/compile amend / |
3ba29a5
to
740142a
Compare
/rebase |
740142a
to
caaea84
Compare
I rebased on top of the current master and rebuild the js. Hope that tests pass now and we can merge after. |
We realized with our users that when the apps Text and ONLYOFFICE are installed in parallel, this is a bit confusing. You can see a screenshot here, in french: https://forge.liiib.re/indiehost/tech/plateforme/-/issues/217#note_9733 So we propose this change. In relation to this change in [onlyoffice app](ONLYOFFICE/onlyoffice-nextcloud#617). Signed-off-by: Pierre Ozoux <pierre@ozoux.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
caaea84
to
ce9daac
Compare
cypress failure is not related.Will look into that separately. |
@max-nextcloud do you think it is possible to backport this little change? Or is it a "big" change, and will have to wait 25th? |
I'd be okay with backporting this - I'll open a backport pr to have the discussion there. |
/backport to stable24 |
/backport to stable23 |
We realized with our users that when the apps Text and ONLYOFFICE are installed in parallel, this is a bit confusing.
You can see a screenshot here, in french:
https://forge.liiib.re/indiehost/tech/plateforme/-/issues/217#note_9733
So we propose this change.
In relation to this change in onlyoffice app.