Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Changes menu entry. #2427

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented May 20, 2022

backport of #2292

@backportbot-nextcloud backportbot-nextcloud bot added the enhancement New feature or request label May 20, 2022
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 24.0.2 milestone May 20, 2022
@max-nextcloud
Copy link
Collaborator

@pierreozoux asked if this could be backported.... so I opened this PR to discuss this here. I'd say it's fine from my side - but i don't have much inside into translation workflows - Do stable branches get translation updates with new terms like this one?

@pierreozoux
Copy link
Member

I think translation is continuously translated, so I wouldn't worry much about this one.
I see the node failing, is it a "normal" fail that is also failing master?
Or can I fix it?

Copy link
Member

@pierreozoux pierreozoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juliusknorr
Copy link
Member

Yes, translations will get back ported automatically: https://github.com/nextcloud/text/blame/stable24/l10n/de_DE.js#L4

@juliusknorr
Copy link
Member

/rebase

@nextcloud-command nextcloud-command force-pushed the backport/2292/stable24 branch from ed92e13 to 27fbefa Compare June 7, 2022 22:29
@juliusknorr
Copy link
Member

/compile amend /

We realized with our users that when the apps Text and ONLYOFFICE are installed in parallel, this is a bit confusing.

You can see a screenshot here, in french:
https://forge.liiib.re/indiehost/tech/plateforme/-/issues/217#note_9733

So we propose this change.

In relation to this change in [onlyoffice app](ONLYOFFICE/onlyoffice-nextcloud#617).

Signed-off-by: Pierre Ozoux <pierre@ozoux.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the backport/2292/stable24 branch from 27fbefa to ce1441b Compare June 7, 2022 22:35
@juliusknorr juliusknorr merged commit cb8af7f into stable24 Jun 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/2292/stable24 branch June 7, 2022 22:44
@blizzz blizzz mentioned this pull request Jun 9, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants