Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only scroll images into view when they're added #3532

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Dec 7, 2022

Instead of scrolling each image into view after it's been loaded, only scroll images into view when they got added to the document.

Fixes: #3531

Signed-off-by: Jonas jonas@freesources.org

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo- mejo- added bug Something isn't working 3. to review labels Dec 7, 2022
@mejo-
Copy link
Member Author

mejo- commented Dec 7, 2022

/backport to stable25

@mejo-
Copy link
Member Author

mejo- commented Dec 7, 2022

/backport to stable24

@cypress
Copy link

cypress bot commented Dec 7, 2022



Test summary

111 0 0 0Flakiness 1


Run details

Project Text
Status Passed
Commit d8683b0
Started Dec 7, 2022 4:01 PM
Ended Dec 7, 2022 4:08 PM
Duration 06:48 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/links.spec.js Flakiness
1 test link marks > link preview > shows a link preview

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense. Thanks for looking into it.

Instead of scrolling each image into view after it's been loaded, only
scroll images into view when they got added to the document.

Fixes: #3531

Signed-off-by: Jonas <jonas@freesources.org>
@max-nextcloud max-nextcloud force-pushed the fix/image_scrollintoview branch from d8683b0 to 7f6f683 Compare December 7, 2022 16:35
@max-nextcloud
Copy link
Collaborator

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@max-nextcloud max-nextcloud merged commit ae66e2a into master Dec 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/image_scrollintoview branch December 7, 2022 16:53
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't scroll existing images into view once loaded
4 participants