Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Only scroll images into view when they're added #3534

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

max-nextcloud
Copy link
Collaborator

Instead of scrolling each image into view after it's been loaded, only scroll images into view when they got added to the document.

Fixes: #3531
Backports: #3532

@max-nextcloud max-nextcloud changed the title Only scroll images into view when they're added [stable24] Only scroll images into view when they're added Dec 7, 2022
@cypress
Copy link

cypress bot commented Dec 7, 2022



Test summary

51 0 0 0


Run details

Project Text
Status Passed
Commit 77c92ce ℹ️
Started Dec 9, 2022 3:14 PM
Ended Dec 9, 2022 3:17 PM
Duration 03:02 💡
OS Linux Ubuntu - 22.04
Browser Electron 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Instead of scrolling each image into view after it's been loaded, only
scroll images into view when they got added to the document.

Fixes: #3531

Signed-off-by: Jonas <jonas@freesources.org>
@juliusknorr juliusknorr force-pushed the backport/3532/stable24 branch from 65bf6dc to 691a432 Compare December 9, 2022 15:03
@juliusknorr
Copy link
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr juliusknorr merged commit b080cf1 into stable24 Dec 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/3532/stable24 branch December 9, 2022 15:32
@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
8 tasks
@blizzz blizzz mentioned this pull request Jan 11, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants