Skip to content

Conversation

@max-nextcloud
Copy link
Collaborator

render is called first.
It awaits the import of FilesHeaderRichWorkspaceView.
updated is called in the meantime.
It failed during the if block as FilesHeaderRichWorkspaceInstance is not available yet.
render continues with the folder it started with, which had no workspace.

Not sure this is a good solution. But it does the trick for me.

`render` is called first.
It awaits the import of `FilesHeaderRichWorkspaceView`.
`updated` is called in the meantime.
It failed during the if block as `FilesHeaderRichWorkspaceInstance` is not available yet.
`render` continues with the folder it started with, which had no workspace.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud requested a review from mejo- as a code owner July 14, 2025 16:00
@max-nextcloud max-nextcloud requested a review from skjnldsv July 14, 2025 16:00
@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.70%. Comparing base (d264a64) to head (09e7f1d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7448      +/-   ##
==========================================
- Coverage   59.61%   52.70%   -6.92%     
==========================================
  Files         494      495       +1     
  Lines       37376    42284    +4908     
  Branches     1088     1089       +1     
==========================================
+ Hits        22282    22284       +2     
- Misses      14988    19893    +4905     
- Partials      106      107       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-nextcloud max-nextcloud merged commit d11221c into main Jul 14, 2025
66 checks passed
@max-nextcloud max-nextcloud deleted the fix/workspace-race branch July 14, 2025 17:25
@max-nextcloud
Copy link
Collaborator Author

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants