Skip to content

[stable31] fix(workspace): fix race condition when loading #7449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

[stable31] fix(workspace): fix race condition when loading #7449

merged 1 commit into from
Jul 14, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Jul 14, 2025

Backport of PR #7448

@max-nextcloud @backportbot
fix(workspace): fix race condition when loading
80016bb 
`render` is called first.
It awaits the import of `FilesHeaderRichWorkspaceView`.
`updated` is called in the meantime.
It failed during the if block as `FilesHeaderRichWorkspaceInstance` is not available yet.
`render` continues with the folder it started with, which had no workspace.

Signed-off-by: Max <max@nextcloud.com>
@backportbot backportbot bot requested a review from skjnldsv July 14, 2025 17:28
@backportbot backportbot bot added this to the Nextcloud 31.0.8 milestone Jul 14, 2025
@max-nextcloud max-nextcloud enabled auto-merge July 14, 2025 17:28
@codecov
Copy link

codecov bot commented Jul 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.46%. Comparing base (9bf1e34) to head (80016bb).
Report is 5 commits behind head on stable31.

Additional details and impacted files 
@@            Coverage Diff            @@
##           stable31    #7449   +/-   ##
=========================================
  Coverage     58.46%   58.46%           
=========================================
  Files           289      289           
  Lines         36265    36266    +1     
  Branches        839      839           
=========================================
+ Hits          21203    21204    +1     
  Misses        14943    14943           
  Partials        119      119

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-nextcloud max-nextcloud merged commit 9e480ec into stable31 Jul 14, 2025
64 checks passed
@max-nextcloud max-nextcloud deleted the backport/7448/stable31 branch July 14, 2025 17:37
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 5, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@mejo- mejo- Awaiting requested review from mejo- mejo- is a code owner

Assignees

@max-nextcloud max-nextcloud

Labels

3. to review

Projects

None yet

Milestone

Nextcloud 31.0.8

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @max-nextcloud