Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Polish #26

Merged
merged 2 commits into from
Aug 9, 2016
Merged

Release Polish #26

merged 2 commits into from
Aug 9, 2016

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Aug 9, 2016

For: nextcloud/server#735

  • Save next to title
  • Slide extra options in/out

CC: @jancborchardt @LukasReschke @schiessle @icewind1991 @blizzz @MorrisJobke

@rullzer rullzer added this to the Nextcloud 11.0 milestone Aug 9, 2016
@LukasReschke LukasReschke merged commit 1d75257 into master Aug 9, 2016
@LukasReschke LukasReschke deleted the polish branch August 9, 2016 18:49
@MorrisJobke
Copy link
Member

Backport to stable10?

@@ -5,7 +5,7 @@
/** @var array $_ */
?>
<form id="user-saml" class="section" action="#" method="post">
<h2><?php p($l->t('SAML')); ?></h2>
<h2 class="inlineblock"><?php p($l->t('SAML')); ?></h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the inlineblock for? Other templates don't have it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows the save notification to appear on the same level right beside the heading

@LukasReschke
Copy link
Member

Backport to stable10?

Already done. https://github.com/nextcloud/user_saml/commits/stable10

@MorrisJobke
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants