Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release review polishing #735

Closed
59 of 67 tasks
MorrisJobke opened this issue Aug 4, 2016 · 24 comments
Closed
59 of 67 tasks

Release review polishing #735

MorrisJobke opened this issue Aug 4, 2016 · 24 comments
Labels
bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Milestone
Nextcloud 10.0.2

Comments

@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 4, 2016 •
edited
Loading

  • delete button in slideshow (next to name) @oparoz - moved to Nextcloud 11 release review #2134
  • files sidebar
    • think about "Hide file listing"
  • apps:
    • proper descriptions (3 sentences)
    • external sites doesn't work (without page reload)
  • admin settings
    • external sites: remove PNG, show default icon next to button, Rename drop down to "Change different icon"
    • left sidebar has white space blocked on bottom even if there is no settings button
@MorrisJobke MorrisJobke added bug design Design, UI, UX, etc. labels Aug 4, 2016
@MorrisJobke MorrisJobke added this to the Nextcloud 10.0 milestone Aug 4, 2016
@MorrisJobke
Copy link
Member Author

cc @Ivansss @blizzz @rullzer @hagengraf @schiessle @jancborchardt @nickvergessen @LukasReschke @karlitschek

@MorrisJobke MorrisJobke mentioned this issue Aug 4, 2016
Closed
5 tasks
@jancborchardt jancborchardt added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Aug 5, 2016
@jancborchardt
Copy link
Member

Also adding »starter issue« cause lots of these items are nice small issues to fix. :)

@MorrisJobke
Copy link
Member Author

cc @Mar1u5 @Bugsbane

@MorrisJobke
Copy link
Member Author

notification icon in top left is white instaed of black

@juliushaertl I think this is one of the remaining tasks for #455 - Could you have a look into this? The survey app for example creates after installation a notification so you could check this.

@nickvergessen nickvergessen mentioned this issue Aug 5, 2016
Merged
@nickvergessen
Copy link
Member

I made all PRs against master, but can't take care of backports anymore before my vacation, please take care of that @schiessle
https://gist.github.com/nickvergessen/6b31b36f4dbd341e9984c1910b66ca80

@juliusknorr
Copy link
Member

@MorrisJobke I'll try to fix this at the beginning of next week.

@Bugsbane
Copy link
Member

Bugsbane commented Aug 7, 2016 •
edited
Loading

How would this be for an example video file? It's 413kb. It's a rough draft at the moment, but if it works, there's a number of small polishing things I'd do. I can also render it in webm / ogv if that helps.

Also, what's needed for the icons? I'd be interested in working on those. Are we talking about 16x16 monochrome icons as in the sidebar, or something larger/more detailed / more colourful? Is this for use in Nextcloud itself, or the release announcement? A link to any issue number(s) would be ideal.

@MorrisJobke
Copy link
Member Author

How would this be for an example video file? It's 413kb

Looks nice, but there was already somebody from the forums who also did a intro logo. You could see it at https://www.youtube.com/watch?v=yqr22XG8P4w

I like both 😄 Maye also something for @jospoortvliet

@schiessle schiessle mentioned this issue Aug 8, 2016
Merged
@Bugsbane
Copy link
Member

Bugsbane commented Aug 8, 2016

somebody from the forums who also did a intro logo

I don't see them as competing. One was designed as a 2 second ident for the start of videos, which it does well, the other as a slightly longer sample video for new users. They both introduce the same logo in the same colours, just with different animations, speeds and audio that matches their different use cases.

Major advertising companies play with how icons / trademarks are introduced in almost every ad campaign. As long as your branding elements (eg. logo, colours, overall mood etc) are consistent, changing other parts up keeps things fresh and engaging with the audience.

Anyway, here's a reworked video draft, that incorporates one of the music tracks from one of the current videos for a very different mood, along with some polishing, and we'll see what Jos has to say:
Video Link

I'm assuming that if Nexcloud Gmbh is already using these in public videos that we have the right to do so, right @jospoortvliet?

@schiessle schiessle mentioned this issue Aug 8, 2016
Merged
This was referenced Aug 9, 2016
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@schiessle schiessle mentioned this issue Aug 9, 2016
Merged
This was referenced Aug 9, 2016
Merged
Merged
Merged
@karlitschek
Copy link
Member

The youtube video looks nice. But it think it is a bit much to ship with the release. let's go with the short 'intro' video only.

@Bugsbane
Copy link
Member

let's go with the short 'intro' video only.

Which one exactly do you mean @karlitschek ? This one (with the wind sound) or this one (my preference, with the music - although I can switch that for a CC-BY track if preferred)?

MorrisJobke added a commit to nextcloud/notifications that referenced this issue Aug 10, 2016
@MorrisJobke
Fix style of notification
9a8fcae 
* normal line-height
* no gray background on hover
* underline on hover to detect that it is clickable
* pull primary buttons to right
* white color for primary button instead of grey (looked disabled)
* for nextcloud/server#735
@MorrisJobke MorrisJobke mentioned this issue Aug 10, 2016
Merged
@MorrisJobke
Copy link
Member Author

icons: federation, password policy, survey client, theming, update notification, retention, saml authentication

@Bugsbane Do you maybe want to help out with the remaining icons? 😃

@karlitschek
Copy link
Member

@Bugsbane I meant the one i already committed here: https://github.com/nextcloud/example-files/blob/master/Nextcloud.mp4 Not sure we need sound at all for this 5 seconds

@MorrisJobke
Copy link
Member Author

icons: federation, password policy, survey client, theming, update notification, retention, saml authentication
@Bugsbane Do you maybe want to help out with the remaining icons? 😃

Or @jancborchardt

schiessle pushed a commit to nextcloud/notifications that referenced this issue Aug 10, 2016
@MorrisJobke @schiessle
Fix style of notification
1e4f520 
* normal line-height
* no gray background on hover
* underline on hover to detect that it is clickable
* pull primary buttons to right
* white color for primary button instead of grey (looked disabled)
* for nextcloud/server#735
@Bugsbane
Copy link
Member

Bugsbane commented Aug 11, 2016 •
edited
Loading

Ah, OK. Didn't realize something was already committed. That works. Some kind of audio would be an improvement imo, but what we have fits the bill. I'll have a play with some sound design and maybe run something by Jos.

@MorrisJobke - I'd absolutely be up for working on those icons this weekend, at least some of them (probably federation, survey client, update notification and theming to begin with). Where are they used so I can see what size/style the designs need to fit into. Eg. Are they all 32x32px app icons like the server monitor icon, or 16x16px sidebar icons like the tags icon, a mix or something else altogether?

I'd also be interested in helping out with any marketing material needed for the release.

@jancborchardt
Copy link
Member

jancborchardt commented Aug 11, 2016 •
edited
Loading

@Bugsbane awesome, help with the icons would be cool! :) Federation could be a simple copy of the share icon for now.
In general they are only visible in the Apps management, so, 32x32px. We might want to show it in the left navigation of the admin settings in the future though, so all icons should generally be pixel-perfect on a 16x16px grid.

@phsc84
Copy link

phsc84 commented Aug 12, 2016

Do you also plan to backport reasonable changes from Owncloud master?
owncloud/core#25652
owncloud/core#25763
owncloud/core#25767

@MorrisJobke
Copy link
Member Author

Do you also plan to backport reasonable changes from Owncloud master?

Yes. But this is not part of this ticket here. We do have a look on the upstream changes regularly.

@jancborchardt jancborchardt added the papercut Annoying recurring issue with possibly simple fix. label Aug 12, 2016
@Bugsbane Bugsbane mentioned this issue Aug 13, 2016
Closed
7 tasks
@schiessle schiessle mentioned this issue Aug 15, 2016
Merged
@nickvergessen nickvergessen mentioned this issue Aug 17, 2016
Merged
@juliusknorr juliusknorr mentioned this issue Aug 30, 2016
Merged
@tflidd tflidd mentioned this issue Sep 1, 2016
Closed
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Sep 14, 2016 •
edited
Loading

This is what is remaining:

  • delete button in slideshow (next to name) @oparoz
  • files sidebar
  • apps:
  • personal settings:
  • admin settings
    • external sites: remove PNG, show default icon next to button, Rename drop down to "Change different icon"
    • left sidebar has white space blocked on bottom even if there is no settings button

@MorrisJobke
Copy link
Member Author

There is nothing for 10.0.1 in here -> move to 10.0.2

@MorrisJobke MorrisJobke mentioned this issue Nov 18, 2016
Closed
67 tasks
@MorrisJobke
Copy link
Member Author

I moved remaining stuff over to #2134

@nickvergessen nickvergessen mentioned this issue Dec 15, 2016
Closed
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 10.0.2
Development

No branches or pull requests
8 participants
@nickvergessen @MorrisJobke @Bugsbane @karlitschek @LukasReschke @jancborchardt @phsc84 @juliusknorr