How to polish code, eg: OC\User #25767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@butonic, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rullzer, @LukasReschke and @ChristophWurst to be potential reviewers |
|
looks good 👍 |
|
Could you also add the missing PHPDoc? |
|
Sure thing. |
butonic
force-pushed
the
polish-user-code
branch
from
936b76f to
de0b02e
Compare
|
Looks good, OC didn't explode on my env like it sometimes does with |
67 tasks
|
@butonic Do you know if there are good free alternatives to PHPStorm? |
|
@tflidd jentbrains offer a free of charge open source license - https://www.jetbrains.com/buy/opensource/ |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves as an example for polishing some of the issues that PHPStorm spits out when pressing "Inspect Code ...". They should be limited to a namespace to keep it reviewable.
Inspecting a subfolder:
Before
After
The four commits all address a single type of code smell. Feel free to just submit PRs for a single smell.