test(psalm): fix missing template-implements hint #217
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
come-nc
reviewed
Nov 16, 2023
| @@ -33,6 +33,9 @@ | |||
| use OCP\WorkflowEngine\Events\RegisterOperationsEvent; | |||
| use Psr\Container\ContainerInterface; | |||
|
|
|||
| /** | |||
| * @template-implements IEventListener<Event> | |||
There was a problem hiding this comment.
Should be @template-implements IEventListener<RegisterOperationsEvent> ideally. (Psalm may complain about the instanceof check below being redundant, but it makes sure that psalm checks this gets registered as a listener only for the right event type)
There was a problem hiding this comment.
I see. Most usages seem to be not ideal then, not just here. Thanks for pointing it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes last Psalm "finding" as seen in https://github.com/nextcloud/workflow_script/actions/runs/5982268149/job/16231148858