Skip to content

test(psalm): fix missing template-implements hint #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2023
Merged

test(psalm): fix missing template-implements hint #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/Listener/RegisterFlowOperationsListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
use OCP\WorkflowEngine\Events\RegisterOperationsEvent;
use Psr\Container\ContainerInterface;

/**
* @template-implements IEventListener<Event>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be @template-implements IEventListener<RegisterOperationsEvent> ideally. (Psalm may complain about the instanceof check below being redundant, but it makes sure that psalm checks this gets registered as a listener only for the right event type)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Most usages seem to be not ideal then, not just here. Thanks for pointing it out.

*/
class RegisterFlowOperationsListener implements IEventListener {
private ContainerInterface $container;

Expand Down