Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing ::clerk/width does not report spec failures for invalid values #217

Closed
dgtized opened this issue Sep 22, 2022 · 1 comment
Closed

Comments

@dgtized
Copy link

dgtized commented Sep 22, 2022

Following through in the workshop, in https://github.com/nextjournal/clerk-demo/blob/master/workshop/exercises/ex_2_table_viewer.clj#L45:

changing ::clerk/width :full to ::clerk/width :foo does not report an error for invalid values .

In contrast, invalid values for :code in ::clerk/visibility {:code :fold} report spec failures on invalid states.

Thanks!

mk pushed a commit that referenced this issue Nov 23, 2022
This is a first draft for providing custom classes to viewers and the notebook viewer which should allow for most use cases and does not require actually overriding the base styles. Once a `:nextjournal.clerk/css-class` is available on the viewer or in document settings, the available class will be used and no further viewer classes will be assigned.

Also add validation for `:nextjournal.clerk/width` fixing #217.
@mk
Copy link
Member

mk commented Nov 23, 2022

Closed by #294.

@mk mk closed this as completed Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants