-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local deps? #30
Comments
True, this is annoying and Clerk should support working completely offline. I'll revisit this after #36 which switches to tailwind's play cdn and is another thing to consider for offline support. |
Working on this. |
Anyone? :) |
Was chatting with @borkdude about resuming work on this. When we actually tried it we discovered to my surprise that Clerk does work fine when offline, as long as you previously had a notebook with the viewers you're using open. This includes KaTeX, Vega, Plotly etc which are all cached in the browser and do survive a reload. So this is a lot better than how I thought it worked. We might want to consider bundling these deps in the jar in the future but would track that in a separate issue when the need arises. |
Yes, I believe I was on a plane while debugging and had to do a hard refresh which put a hard stop to any development. Hard refreshes are somewhat common in moments of debugging despair. I think this is still a valid issue and it seems the solution is straightforward. |
f35635f implements caching of all assets used by Clerk in the browser's ServiceWorker, finally. |
I just painfully found out on a flight that clerk's frontend deps (in my case vega, vega lite, vega embed and katex) are not included in the source and therefore failed fetching in-browser. This is an edge case for sure, but since clerk advertises itself being local first, I think it would be nice for clerk to be able to work offline.
The text was updated successfully, but these errors were encountered: