Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidenotes #392

Merged
merged 17 commits into from
Jan 25, 2023
Merged

Sidenotes #392

merged 17 commits into from
Jan 25, 2023

Conversation

zampino
Copy link
Collaborator

@zampino zampino commented Jan 23, 2023 •
edited
Loading

This aims at getting a more solid and flexible handling of foot/sidenotes.

  • Fix sidenotes in paragraphs with marks
  • Sidenotes on narrow viewports
  • Keep sidenote ref count across blocks.
  • Awaits markdown release after Footnotes markdown#11

@zampino
Copy link
Collaborator Author

zampino commented Jan 24, 2023

CleanShot 2023-01-24 at 09 54 56@2x

This is currently happening with Chrome Version 101.0.4951.64 (which is not the latest).

@zampino zampino marked this pull request as ready for review January 24, 2023 14:57
@mk mk changed the title Footnotes Sidenotes Jan 24, 2023
@mk mk merged commit 990749d into main Jan 25, 2023
@mk mk deleted the footnotes branch January 25, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zampino @mk @philippamarkovics