Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clerk double-builds notebooks from :index, :paths #405

Closed
sritchie opened this issue Feb 4, 2023 · 1 comment
Closed

Clerk double-builds notebooks from :index, :paths #405

sritchie opened this issue Feb 4, 2023 · 1 comment

Comments

@sritchie
Copy link
Collaborator

sritchie commented Feb 4, 2023

If a notebook is set as :index, but is also specified in :paths (or picked up by a glob like src/** in :paths, it's built twice:

[sritchie@wintermute ~/code/clj/clerk-repro (main)]$ clj -X:nextjournal/clerk
👷🏼 Clerk is building 2 notebooks…
🧐 Parsing… Done in 45.463ms. ✅
🔬 Analyzing… Done in 156.340ms. ✅
🔨 Building "src/clerk_repro/notebook.clj"… Done in 10.982ms. ✅
🔨 Building "src/clerk_repro/notebook.clj"… Done in 6.527ms. ✅

See https://github.com/sritchie/clerk-repro,

clj -X:nextjournal/clerk

This is a cheap notebook so it doesn't matter, but for more expensive notebooks (like some of the physics simulations) this would be an issue.

@mk
Copy link
Member

mk commented Feb 4, 2023

@sritchie good catch, fixed with 7222881.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants