Extract ns with render-fns and refer to them by full name #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mk
changed the title
:render-fns and refer to them by full name
mk
changed the title
:render-fns and refer to them by full name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first big step towards making the render-fn part of the viewer api more self-explanatory. We're splitting up the sci-viewer into sci-env and render. Also consistently prefix all render functions and refer to them in viewer using their fully-qualified names so folks can actually jump to definition.
Also start getting rid of most confusing where the exposed var in the sci context would carry a different name than in the defining ns. More cleanup will still follow here.