Extract hooks to own ns, inline code viewer and let it use hooks #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zampino
commented
Nov 2, 2022
•
zampino
commented
- inlines code viewer in render namespace
- uses React hooks to embed codemirror into DOM
zampino
commented
Nov 10, 2022
src/nextjournal/clerk/render.cljs
Outdated
| (def render-code code/viewer) | ||
|
|
||
| (defn render-code [value] | ||
| (let [ref (use-ref nil)] |
There was a problem hiding this comment.
@mhuebert is use-effect right choice here? Effect cleanup has the codemirror instance in scope in this way. Do you think there's a better way to do this?
# Conflicts: # resources/viewer-js-hash
mk
changed the title
render-code to be based on hooks
mk
changed the title
render-code to be based on hooks
|
This can be merged from my side, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.